Skip to content

Add new frame fields for metric kit flamegraphs #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
noahsmartin wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Draft

Add new frame fields for metric kit flamegraphs #5539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions relay-event-schema/src/protocol/stacktrace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ pub struct Frame {
#[metastructure(skip_serialization = "null")]
pub context_line: Annotated<String>,

/// The index of the parent frame, used for flamegraphs provided by iOS.
#[metastructure(skip_serialization = "null")]
pub parent_index: Annotated<i64>,

/// The number of times this frame was sampled, used for flamegraphs provided by iOS.
#[metastructure(skip_serialization = "null")]
pub sample_count: Annotated<u64>,

/// Source code of the lines after `lineno`.
#[metastructure(skip_serialization = "empty")]
pub post_context: Annotated<Array<String>>,
Expand Down Expand Up @@ -600,6 +608,8 @@ mod tests {
thread_id: Annotated::new(ThreadId::Int(7)),
other: Default::default(),
}),
parent_index: Annotated::empty(),
sample_count: Annotated::empty(),
other: {
let mut vars = Object::new();
vars.insert(
Expand Down
Loading