Making setOutput in SentrySDKLog.swift public to make it possible to forward logs to the JS console#7444
Making setOutput in SentrySDKLog.swift public to make it possible to forward logs to the JS console#7444
setOutput in SentrySDKLog.swift public to make it possible to forward logs to the JS console#7444Conversation
logs to the JS console
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Making `setOutput` in `SentrySDKLog.swift` public to make it possible to forward logs to the JS console ([#7444](https://github.com/getsentry/sentry-cocoa/pull/7444))If none of the above apply, you can opt out of this check by adding |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7444 +/- ##
=============================================
- Coverage 85.335% 85.307% -0.028%
=============================================
Files 480 480
Lines 28620 28621 +1
Branches 12376 12394 +18
=============================================
- Hits 24423 24416 -7
- Misses 4149 4158 +9
+ Partials 48 47 -1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
itaybre
left a comment
There was a problem hiding this comment.
I believe this should be set through https://github.com/getsentry/sentry-cocoa/blob/main/Sources/Sentry/Public/PrivateSentrySDKOnly.h
|
@itaybre done, check it out again |
251c364 to
fc7a64f
Compare
philprime
left a comment
There was a problem hiding this comment.
LGTM, I think you need to run make generate-public-api to regenerate the sdk_api.json
📜 Description
This PR adds one tiny change to the codebase — it makes
setOutputinSentrySDKLog.swiftpublic.That's required by RN SDK (and probably other hybrid SDKs as well) in order to support log forwarding — the ability to see native logs in JS console: getsentry/sentry-react-native#5622
(there are also some formatting changes done here but they were done automatically after I ran
make format)📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.