WIP: Prevent Cocoa SDK from capturing errors that also get captured by .NET#4537
Closed
WIP: Prevent Cocoa SDK from capturing errors that also get captured by .NET#4537
Conversation
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4537 +/- ##
==========================================
+ Coverage 73.39% 73.42% +0.02%
==========================================
Files 479 479
Lines 17506 17506
Branches 3480 3480
==========================================
+ Hits 12849 12854 +5
+ Misses 3776 3773 -3
+ Partials 881 879 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts "Use pre-built version of sentry-cocoa SDK (#3727)" commit d179ec9 and restores the modules/sentry-cocoa Git module checked out at: getsentry/sentry-cocoa#6193
1d91d16 to
7fdaad0
Compare
EnesEfeTokta
reviewed
Dec 8, 2025
EnesEfeTokta
left a comment
There was a problem hiding this comment.
I think it looks okay. Good job.
Collaborator
Author
|
Closing this old draft out of the way, as these were "show-case" changes only. The actual fix is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test bed for:
#skip-changelog