Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4723 +/- ##
==========================================
+ Coverage 73.50% 73.64% +0.14%
==========================================
Files 483 476 -7
Lines 17692 17442 -250
Branches 3492 3453 -39
==========================================
- Hits 13004 12846 -158
+ Misses 3797 3747 -50
+ Partials 891 849 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Ideally we'd run all integration tests against all supported targets (so 9 and 10). The only reason we weren't doing this in the preview1/2 releases was because net10-ios26 didn't exist then. We should no though... this is an important sanity check that everything is working properly. |
jamescrosswell
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Note
I created a separate followup task to deal with additional integration tests: