chore: Integrate godot-kaboom library for crash testing#513
Open
chore: Integrate godot-kaboom library for crash testing#513
Conversation
Move the duplicated get_property() function from sentry-cocoa.SConscript and wasm_split.py into site_scons/utils.py, since site_scons is already on the SCons Python path. Co-Authored-By: Claude <noreply@anthropic.com>
The function reads from a file on disk, so read_property() better communicates the I/O intent to callers. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Allows downloading kaboom debug symbols separately from the addon binaries via `scons kaboom_symbols`. Co-Authored-By: Claude <noreply@anthropic.com>
Support wiping the target directory before extraction (clean) and using a custom version marker file (version_file). This enables kaboom_symbols to track its version independently from the main kaboom addon in the same directory. Also bump kaboom to 0.0.1. Co-Authored-By: Claude <noreply@anthropic.com>
Encapsulate the Command + target/source wiring inside the tool so callers just invoke env.FetchGithubRelease() directly. Simplifies the SConstruct kaboom targets. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
limbonaut
changed the title
limbonaut
changed the title
Refuse to rmtree directories that resolve outside the project root to prevent accidental deletion of unrelated paths. Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
@sentry review |
mujacica
approved these changes
Feb 13, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Use maxsplit=1 in read_property() to avoid silently truncating values that contain '=' (e.g., URLs with query parameters, base64 strings). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate godot-kaboom - a GDExtension library that triggers controlled native crashes for testing Sentry's crash reporting. The repo can be adopted in getsentry.
Adds a general-purpose
FetchGithubReleaseSCons tool that downloads zip assets from GitHub releases with version caching and prefix stripping. Used to fetch the pre-built kaboom addon viascons kaboomand its debug symbols viascons kaboom_symbols.Also extracts the shared
read_property()utility from sentry-cocoa's SConscript intosite_scons/utils.pyfor reuse across tools.Removes the internal
SentrySDK._demo_helper_crash_app()method - crash triggering is now fully handled by the kaboom library. Both the demo project and CLI integration tests (crash-capturecommand) use Kaboom. CI fetches the addon automatically via theprepare-testingaction.