ci(release): Switch from action-prepare-release to Craft#1477
ci(release): Switch from action-prepare-release to Craft#1477
Conversation
This PR migrates from the deprecated action-prepare-release to the new Craft GitHub Actions (reusable workflow or composite action). Changes: - Migrate .github/workflows/release.yml to Craft reusable workflow
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Build / dependencies / internal 🔧
🤖 This preview updates automatically when you update the PR. |
The previous migration incorrectly removed the GitHub App token authentication step. This commit restores it by switching to the composite action pattern which preserves the auth flow.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
.github/workflows/release.yml
Outdated
| env: | ||
| GITHUB_TOKEN: ${{ steps.token.outputs.token }} | ||
| with: | ||
| version: ${{ inputs.version }} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - name: Windows (latest) | ||
| os: windows-latest | ||
| - name: Windows arm64 | ||
| os: windows-11-arm |
There was a problem hiding this comment.
Windows ARM64 build missing architecture specification
Medium Severity
The new Windows arm64 matrix entry specifies os: windows-11-arm but doesn't include any flag to indicate ARM64 architecture. The build scripts in tests/cmake.py and scripts/install-zlib.ps1 have explicit handling for 32-bit builds via TEST_X86 (passing -AWin32 to CMake), but no equivalent handling exists for ARM64. Without an architecture flag like -AARM64, CMake defaults to x64 even on ARM64 Windows, resulting in x64 binaries instead of native ARM64 binaries.
2 participants
Summary
This PR migrates from the deprecated
action-prepare-releaseto the new Craft GitHub Actions.Changes
.github/workflows/release.ymlto Craft reusable workflowDocumentation
See https://getsentry.github.io/craft/github-actions/ for more information.