chore(deps): Bump E2E tests to 0.84.0 by antonis · Pull Request #5492 · getsentry/sentry-react-native

antonis · 2025-12-19T09:14:27Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Bump E2E tests to 0.84.-RC

💡 Motivation and Context

https://github.com/facebook/react-native/releases/tag/v0.84.0

💚 How did you test it?

CI, Manual

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2025-12-19T09:35:12Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	522.54 ms	545.46 ms	22.92 ms
Size	43.75 MiB	48.41 MiB	4.66 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`f70acbf`+dirty	373.39 ms	382.81 ms	9.43 ms
`d9f44bb`+dirty	400.64 ms	431.65 ms	31.01 ms
`f3b058c`+dirty	501.18 ms	536.70 ms	35.52 ms
`8e653ac`+dirty	360.28 ms	372.04 ms	11.76 ms
`eb07ba3`	470.04 ms	473.35 ms	3.31 ms
`74979ac`+dirty	444.68 ms	479.36 ms	34.68 ms
`3bd3f0d`+dirty	447.21 ms	472.31 ms	25.10 ms
`785ffb1`	471.92 ms	460.96 ms	-10.96 ms
`6416d6c`+dirty	407.30 ms	422.00 ms	14.70 ms
`ba75c7c`	367.72 ms	369.16 ms	1.44 ms

App size

Revision	Plain	With Sentry	Diff
`f70acbf`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`d9f44bb`+dirty	43.75 MiB	48.40 MiB	4.64 MiB
`f3b058c`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`8e653ac`+dirty	17.75 MiB	19.75 MiB	2.00 MiB
`eb07ba3`	17.75 MiB	20.15 MiB	2.41 MiB
`74979ac`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`3bd3f0d`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`785ffb1`	17.75 MiB	20.15 MiB	2.41 MiB
`6416d6c`+dirty	43.75 MiB	48.05 MiB	4.30 MiB
`ba75c7c`	17.75 MiB	20.15 MiB	2.41 MiB

Previous results on branch: antonis/rn-0.83.1

Startup times

Revision	Plain	With Sentry	Diff
`23af83f`+dirty	408.82 ms	443.98 ms	35.16 ms

App size

Revision	Plain	With Sentry	Diff
`23af83f`+dirty	43.75 MiB	48.41 MiB	4.66 MiB

github-actions · 2025-12-19T09:36:27Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	372.52 ms	437.27 ms	64.74 ms
Size	43.94 MiB	49.27 MiB	5.33 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`a206511`+dirty	331.54 ms	356.98 ms	25.44 ms
`8ff81c0`+dirty	392.47 ms	431.52 ms	39.05 ms
`170d5ea`+dirty	348.79 ms	406.94 ms	58.15 ms
`bb4ea33`+dirty	360.73 ms	375.02 ms	14.29 ms
`80e4616`+dirty	427.31 ms	461.15 ms	33.84 ms
`9a81842`+dirty	508.08 ms	566.65 ms	58.56 ms
`64cd15c`+dirty	488.79 ms	483.54 ms	-5.24 ms
`6bd9054`+dirty	376.24 ms	407.76 ms	31.52 ms
`73f2455`+dirty	369.33 ms	398.90 ms	29.57 ms
`23080e5`+dirty	347.29 ms	381.87 ms	34.58 ms

App size

Revision	Plain	With Sentry	Diff
`a206511`+dirty	43.94 MiB	48.90 MiB	4.96 MiB
`8ff81c0`+dirty	43.94 MiB	48.87 MiB	4.93 MiB
`170d5ea`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`bb4ea33`+dirty	43.94 MiB	48.91 MiB	4.97 MiB
`80e4616`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`9a81842`+dirty	43.94 MiB	48.91 MiB	4.97 MiB
`64cd15c`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`6bd9054`+dirty	43.94 MiB	48.90 MiB	4.96 MiB
`73f2455`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`23080e5`+dirty	7.15 MiB	8.41 MiB	1.26 MiB

github-actions · 2025-12-19T09:46:32Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1215.50 ms	1216.58 ms	1.08 ms
Size	3.38 MiB	4.78 MiB	1.39 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9b50d32`+dirty	1216.53 ms	1221.64 ms	5.10 ms
`083f560`+dirty	1227.33 ms	1242.02 ms	14.69 ms
`7480abe`+dirty	1220.53 ms	1244.18 ms	23.65 ms
`d1bfbde`+dirty	1216.83 ms	1212.83 ms	-3.99 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`652f785`+dirty	1219.66 ms	1223.62 ms	3.96 ms
`6c36ba5`+dirty	1214.56 ms	1216.52 ms	1.96 ms
`9bf5446`+dirty	1206.20 ms	1206.69 ms	0.48 ms
`f081f58`+dirty	1219.10 ms	1217.57 ms	-1.53 ms
`0dff710`+dirty	1207.23 ms	1203.26 ms	-3.97 ms

App size

Revision	Plain	With Sentry	Diff
`9b50d32`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`083f560`+dirty	2.63 MiB	4.00 MiB	1.36 MiB
`7480abe`+dirty	2.63 MiB	3.96 MiB	1.33 MiB
`d1bfbde`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`652f785`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`6c36ba5`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`9bf5446`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`f081f58`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`0dff710`+dirty	3.44 MiB	4.59 MiB	1.15 MiB

Previous results on branch: antonis/rn-0.83.1

Startup times

Revision	Plain	With Sentry	Diff
`23af83f`+dirty	1218.80 ms	1210.89 ms	-7.91 ms

App size

Revision	Plain	With Sentry	Diff
`23af83f`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

antonis

Blocked on the addition of 0.83.1 in https://github.com/react-native-community/rn-diff-purge

github-actions · 2025-12-19T09:48:01Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1205.59 ms	1210.57 ms	4.98 ms
Size	3.38 MiB	4.78 MiB	1.39 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9b50d32`+dirty	1210.36 ms	1218.41 ms	8.05 ms
`083f560`+dirty	1215.27 ms	1231.96 ms	16.69 ms
`7480abe`+dirty	1219.84 ms	1223.60 ms	3.76 ms
`d1bfbde`+dirty	1221.30 ms	1218.70 ms	-2.60 ms
`a2bb688`+dirty	1244.82 ms	1238.60 ms	-6.22 ms
`652f785`+dirty	1216.42 ms	1212.21 ms	-4.21 ms
`6c36ba5`+dirty	1208.55 ms	1207.38 ms	-1.17 ms
`9bf5446`+dirty	1218.60 ms	1210.45 ms	-8.15 ms
`f081f58`+dirty	1208.37 ms	1215.56 ms	7.19 ms
`0dff710`+dirty	1194.90 ms	1196.15 ms	1.25 ms

App size

Revision	Plain	With Sentry	Diff
`9b50d32`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`083f560`+dirty	3.19 MiB	4.56 MiB	1.38 MiB
`7480abe`+dirty	3.19 MiB	4.53 MiB	1.35 MiB
`d1bfbde`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`a2bb688`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`652f785`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`6c36ba5`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`9bf5446`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`f081f58`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`0dff710`+dirty	3.44 MiB	4.59 MiB	1.15 MiB

Previous results on branch: antonis/rn-0.83.1

Startup times

Revision	Plain	With Sentry	Diff
`23af83f`+dirty	1228.37 ms	1224.07 ms	-4.31 ms

App size

Revision	Plain	With Sentry	Diff
`23af83f`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

alwx · 2025-12-19T21:51:23Z

We don't have any guidelines regarding that but in general I don't think that bumping RN version for e2e tests is that needed for every minor version, it's just too much hassle with not so many benifits. Maybe we should do it only for major versions?

antonis

⚠️ Bumped to 0.84.0-rc.0 and will keep this in draft till the final release

github-actions · 2026-01-16T11:03:40Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

_{🤖 This preview updates automatically when you update the PR.}

antonis

Bumped to RC5

antonis

Bumped to 0.84.0 final since it became available with 5b01251

…guments Enhances the patch script to use install_modules_dependencies() instead of hardcoded React/React-Core dependencies. This is the modern approach for React Native 0.60+ that properly handles all framework configurations (static, dynamic, etc.) and automatically resolves the correct React Native dependencies. This should fix the "Undefined symbols: _RCTRegisterModule" error when building RN 0.84.0 with dynamic frameworks on iOS. The patch now uses the same defensive pattern as RNSentry.podspec, with a fallback to React-Core for older RN versions that don't have install_modules_dependencies defined. Tested locally and verified: - Patch successfully replaces s.dependency "React" - Generated Ruby syntax is valid - Idempotent (safe to run multiple times) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

dev-packages/e2e-tests/patch-scripts/rn.patch.launch-arguments.js

lucas-zimerman

LGTM!

sentry · 2026-02-16T09:21:45Z

dev-packages/e2e-tests/patch-scripts/rn.patch.launch-arguments.js

+      patched = patched.replace(/\s+s\.dependency\s+['"]React['"]\s*\n/g, installModulesDepsBlock + '\n');
+    } else if (hasReactCoreDep) {
+      debug.log("Replacing s.dependency 'React/Core' with install_modules_dependencies(s)");
+      patched = patched.replace(/\s+s\.dependency\s+['"]React\/Core['"]\s*\n/g, installModulesDepsBlock + '\n');
+    } else if (hasReactCoreDepOnly) {
+      debug.log("Replacing s.dependency 'React-Core' with install_modules_dependencies(s)");
+      patched = patched.replace(/\s+s\.dependency\s+['"]React-Core['"]\s*\n/g, installModulesDepsBlock + '\n');
+    }

-  fs.writeFileSync(buildGradlePath, patched);
-  debug.log('Patched react-native-launch-arguments build.gradle successfully!');
+    fs.writeFileSync(podspecPath, patched);
+    debug.log('Patched react-native-launch-arguments podspec successfully!');


Bug: The regex for detecting a dependency is more permissive than the regex for replacing it, which can cause the patch to fail silently while reporting success.
_{Severity: MEDIUM}

Suggested Fix

Unify the detection and replacement logic. Either make the replacement regex more flexible to not require a trailing newline, or make the detection regex stricter to match the replacement's requirements. Additionally, verify that the file content has changed after the replacement operation before reporting success.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: dev-packages/e2e-tests/patch-scripts/rn.patch.launch-arguments.js#L82-L94 Potential issue: The patch script uses different regular expressions for detecting and replacing dependency lines in a podspec file. The detection regex, for example `/s\.dependency\s+['"]React['"]/`, will match a line even if it is not followed by a newline. However, the corresponding replacement regex, ` /\s+s\.dependency\s+['"]React['"]\s*\n/g`, requires a newline `\n` at the end. If a podspec file has a dependency declaration without a trailing newline, the script will detect the dependency, but the replacement will fail. The script does not verify that the replacement was successful, leading to a silent failure where it reports success but the file remains unpatched, which can cause subsequent build failures.

chore(deps): Bump E2E tests to 0.83.1

6d7e56f

antonis added ready-to-merge Triggers the full CI test suite and removed ready-to-merge Triggers the full CI test suite labels Dec 19, 2025

antonis commented Dec 19, 2025

View reviewed changes

antonis added Blocked and removed ready-to-merge Triggers the full CI test suite labels Dec 19, 2025

antonis added 2 commits January 8, 2026 10:33

Merge branch 'main' into antonis/rn-0.83.1

91c5d97

Bump to 0.84.0-rc.0

2b81c80

antonis changed the title ~~chore(deps): Bump E2E tests to 0.83.1~~ chore(deps): Bump E2E tests to 0.84-RC Jan 8, 2026

antonis added the ready-to-merge Triggers the full CI test suite label Jan 8, 2026

antonis commented Jan 8, 2026

View reviewed changes

antonis added 2 commits January 8, 2026 12:01

Fix Build RN 0.84.0-rc.0 legacy hermes ios production dynamic

c9bd738

Iterate on the fix

f666885

antonis removed the ready-to-merge Triggers the full CI test suite label Jan 8, 2026

antonis added 2 commits January 16, 2026 12:04

Update React Native version to 0.84.0-rc.1

d58633f

Merge branch 'main' into antonis/rn-0.83.1

e88d8f6

antonis added the ready-to-merge Triggers the full CI test suite label Jan 16, 2026

antonis added 6 commits January 30, 2026 16:42

Bump to 0.84.0-rc.3

da75b2d

Merge branch 'main' into antonis/rn-0.83.1

26999bb

Merge branch 'main' into antonis/rn-0.83.1

1e0e8e0

Bump to 0.84.0-rc.4

b5ab8c4

Merge branch 'main' into antonis/rn-0.83.1

135da92

Update React Native version from rc.4 to rc.5

a34cc50

antonis commented Feb 6, 2026

View reviewed changes

antonis changed the title ~~chore(deps): Bump E2E tests to 0.84-RC~~ chore(deps): Bump E2E tests to 0.84.0 Feb 12, 2026

Bump to 0.84.0

5b01251

antonis commented Feb 12, 2026

View reviewed changes

antonis and others added 4 commits February 12, 2026 09:45

Merge branch 'main' into antonis/rn-0.83.1

46348ad

Merge branch 'main' into antonis/rn-0.83.1

414e1c4

Merge branch 'main' into antonis/rn-0.83.1

fed421b

antonis marked this pull request as ready for review February 13, 2026 15:28

antonis requested review from alwx and lucas-zimerman as code owners February 13, 2026 15:28

sentry bot reviewed Feb 13, 2026

View reviewed changes

dev-packages/e2e-tests/patch-scripts/rn.patch.launch-arguments.js Show resolved Hide resolved

lucas-zimerman approved these changes Feb 13, 2026

View reviewed changes

antonis added 2 commits February 16, 2026 09:53

Merge branch 'main' into antonis/rn-0.83.1

d0338e4

Merge branch 'main' into antonis/rn-0.83.1

a31efab

antonis enabled auto-merge (squash) February 16, 2026 09:16

antonis merged commit cd5f27f into main Feb 16, 2026
70 of 71 checks passed

antonis deleted the antonis/rn-0.83.1 branch February 16, 2026 09:19

sentry bot reviewed Feb 16, 2026

View reviewed changes

Uh oh!

Conversation

antonis commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/rn-0.83.1

Startup times

App size

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/rn-0.83.1

Startup times

App size

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/rn-0.83.1

Startup times

App size

Uh oh!

alwx commented Dec 19, 2025

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sentry bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

antonis commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2026 •

edited

Loading