feat: Support Linux ARM64 #2470
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+13
to
+22
| platformData: | ||
| Android: | ||
| enabled: 0 | ||
| settings: | ||
| AndroidLibraryDependee: UnityLibrary | ||
| AndroidSharedLibraryType: Executable | ||
| CPU: ARMv7 | ||
| Is16KbAligned: false | ||
| Any: | ||
| enabled: 0 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| Linux64: | ||
| enabled: 0 | ||
| settings: | ||
| CPU: None |
There was a problem hiding this comment.
ARM64 library disabled for all platforms in meta file
High Severity
The arm64/libsentry.so.meta file has Linux64: enabled: 0 and CPU: None, which prevents the ARM64 library from being included in any Unity build. Comparing to the working x86_64/libsentry.so.meta, it correctly sets enabled: 1 and CPU: x86_64 for Standalone: Linux64. The ARM64 meta file needs similar configuration (likely enabled: 1 with CPU: ARM64) to be included in ARM64 Linux builds. Without this fix, the Linux ARM64 support added by this PR won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2466