Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
- Bump Native SDK from v0.12.2 to v0.12.3 ([#2471](https://github.com/getsentry/sentry-unity/pull/2471))
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0123)
- [diff](https://github.com/getsentry/sentry-native/compare/0.12.2...0.12.3)
- Bump CLI from v2.58.4 to v3.1.0 ([#2474](https://github.com/getsentry/sentry-unity/pull/2474))
- [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#310)
- [diff](https://github.com/getsentry/sentry-cli/compare/2.58.4...3.1.0)

## 4.0.0

Expand Down
2 changes: 1 addition & 1 deletion modules/sentry-cli.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version = 2.58.4
version = 3.1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading sentry-cli causes silent symbol upload failures for users with legacy API keys because the process exit code is not checked.
Severity: CRITICAL

Suggested Fix

Check the process.ExitCode after process.WaitForExit() in UploadDebugSymbols and other places where sentry-cli is executed. Log an error and fail the build if the exit code is non-zero. Additionally, add validation to warn users if they are using a deprecated API key instead of a new auth token.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: modules/sentry-cli.properties#L1

Potential issue: The pull request upgrades `sentry-cli` to v3.1.0, which no longer
supports legacy API key authentication. The SDK does not validate the format of the
`Auth` token. In `BuildPostProcess.cs`, the `UploadDebugSymbols` method invokes the
`sentry-cli` process but does not check its `ExitCode` after `process.WaitForExit()`.
When a user with a legacy API key tries to upload symbols, `sentry-cli` exits with an
error, but the build process ignores it and continues silently. This causes symbol
uploads to fail without notification, preventing symbolication of crash reports.

Did we get this right? 👍 / 👎 to inform future reviews.

repo = https://github.com/getsentry/sentry-cli