Skip to content

chore: Use pull_request_target for changelog preview #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Jan 16, 2026
+1 −1
Merged

chore: Use pull_request_target for changelog preview #2483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Changelog Preview
on:
pull_request:
pull_request_target:
Copy link

@cursor cursor bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Privileged workflow trigger with inherited secrets needs verification

Medium Severity

The change to pull_request_target combined with secrets: inherit and write permissions (contents: write, pull-requests: write) creates a privileged execution context for fork PRs. This is a known security-sensitive pattern ("pwn request"). The safety depends entirely on the external workflow at getsentry/craft/.github/workflows/changelog-preview.yml@v2 not executing PR-controlled code or processing untrusted inputs unsafely. The PR's security claims about that workflow cannot be verified from this diff alone and warrant independent confirmation.

Additional Locations (1)

Fix in Cursor Fix in Web

types:
- opened
- synchronize
Expand Down
Loading