fix(skill-scanner): Handle None values in YAML description field#57
Open
ericapisani wants to merge 1 commit intomainfrom
Open
fix(skill-scanner): Handle None values in YAML description field#57ericapisani wants to merge 1 commit intomainfrom
ericapisani wants to merge 1 commit intomainfrom
Conversation
The compute_description_body_overlap function could crash with an AttributeError when a skill's YAML description field is None or empty. Add a null check before accessing the description value. Also remove unused imports (os, unicodedata) that were flagged in code review. Fixes getsentry/sentry-python#5485 (comment) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compute_description_body_overlap function could crash with an AttributeError when a skill's YAML description field is None or empty.
Add a null check before accessing the description value.
Also remove unused imports (os, unicodedata) that were flagged in code review.
Fixes getsentry/sentry-python#5485 (comment) and getsentry/sentry-python#5485 (comment)