fix(iterate-pr): Reorder workflow to catch late review bot feedback#58
Merged
fix(iterate-pr): Reorder workflow to catch late review bot feedback#58
Conversation
Gather and address existing review feedback before checking CI status, and add a post-CI delayed re-check (sleep 10s + re-fetch) to catch review bot comments that arrive after CI checks turn green. Also add a skill-creator rule to agents-md writing guidelines. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iterate-pr skill had a race condition: after CI completes, review bot
feedback (Sentry, Warden, Bugbot, etc.) may not yet be visible. The
workflow checked CI first, then feedback once — but bots often post
seconds after CI checks turn green, causing the skill to declare success
before seeing actionable feedback.
iterate-pr changes:
comments are handled early
sleep 10then re-fetch feedback tocatch late-arriving review bot comments
agents-md change:
/skill-creatorrule to Writing Rules: always use it when creatingor updating skills