Skip to content

fix: don't error on static assignment if rebalancing should take place #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmckerry merged 6 commits into from
May 1, 2025
Merged

fix: don't error on static assignment if rebalancing should take place #29

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4efbf4
fix: don't error on static assignment if rebalancing should take place
bmckerry May 1, 2025
3c081f1
update evaluate tests
bmckerry May 1, 2025
4020cb9
more logging
bmckerry May 1, 2025
56f6641
handle static errors in frequecy.go instead of evaluate.go
bmckerry May 1, 2025
496650d
Revert "update evaluate tests"
bmckerry May 1, 2025
83194e0
Revert "more logging"
bmckerry May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/apply/rebalancers/frequency.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/segmentio/topicctl/pkg/apply/assigners"
"github.com/segmentio/topicctl/pkg/apply/pickers"
"github.com/segmentio/topicctl/pkg/config"
log "github.com/sirupsen/logrus"
)

// FrequencyRebalancer is a Rebalancer that rebalances to achieve in-topic balance among
Expand Down Expand Up @@ -67,7 +68,13 @@ func (f *FrequencyRebalancer) Rebalance(
if err != nil {
return nil, err
} else if !ok {
return nil, fmt.Errorf("starting assignments on topic %s do not satisfy placement config - assignments: %#v", topic, curr)
// If we're doing a static rebalance, we don't expect the existing assignments to
// satify the placement config
if f.placementConfig.Strategy == config.PlacementStrategyStatic {
log.Info("Current partition assignment does not match static assignment, rebalancing will take place")
} else {
Comment on lines +72 to +75
Copy link
Member Author

@bmckerry bmckerry May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When applying a new topic, if EvaluateAssignments returns false, topicctl knows it needs to adjust the partition placement of the new topic to match the desired placement strategy: https://github.com/getsentry/topicctl/blob/master/pkg/apply/apply.go#L831

When rebalancing a topic (which is what this frequency.go file is used for), if EvaluateAssignments returns false, topicctl considers that to be an error. I've updated it so that if we're using static placement, topicctl doesn't error out here when rebalancing.

return nil, fmt.Errorf("starting assignments on topic %s do not satisfy placement config - assignments: %#v", topic, curr)
}
}

desired := admin.CopyAssignments(curr)
Expand Down