Manage non topic specific topicctl errors #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Sep 9, 2025
| try: | ||
| topic = json.loads(line) | ||
| except json.JSONDecodeError: | ||
| title = f"Topicctl failed to apply in region {SENTRY_REGION}" |
Member
There was a problem hiding this comment.
can you add the line here? the problem to me is that we don't know the error that comes from topicctl. see #31
Author
There was a problem hiding this comment.
Added the whole exception repr in the payload.
Author
There was a problem hiding this comment.
By the way. I know the issue. The payload was None because the error was that the config was not consistent
Member
There was a problem hiding this comment.
By the way. I know the issue. The payload was None because the error was that the config was not consistent
yeah you do but i still have no idea where to look for topicctl errors, so I think it would be best if the parse_and_notify script just posted all diagnostic info to slack or some other high-vis channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an error in applying one specific topic we serialize the error
in the json output and the parser script manages it properly.
Though, if the whole process fails because the config is invalid,
we do not produce any json and parse_and_notify fails without sending
notifications.
THis prodices a valid json and tries to send a notification when json is invalid