cuda : fix "V is K view" check for non-unified KV cache#19145
Merged
cuda : fix "V is K view" check for non-unified KV cache#19145
Conversation
ggerganov
force-pushed
the
gg/cuda-fix-v-is-k-view-check
branch
from
89697cf to
c9f3020
Compare
github-actions
bot
added
Nvidia GPU
JohannesGaessler
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19057
We weren't handling the case where both V and K are views of the same data with the same offset different from 0. This happens with split KV cache (e.g.
--parallel 4 --no-kv-unified) and causes the flash attention to fall back to the CPU in such cases.