Skip to content

vulkan: fix non-contig rope #19299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeffbolznv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vulkan: fix non-contig rope #19299

jeffbolznv wants to merge 1 commit into from
+100 −95

Conversation

@jeffbolznv
Copy link
Collaborator

@jeffbolznv jeffbolznv commented Feb 3, 2026

For #19296.

@jeffbolznv jeffbolznv requested a review from 0cc4m as a code owner February 3, 2026 18:23
@jeffbolznv jeffbolznv mentioned this pull request Feb 3, 2026
Open
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Feb 3, 2026
LostRuins
LostRuins approved these changes Feb 4, 2026
View reviewed changes
Copy link
Collaborator

@LostRuins LostRuins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it fixes #19292 for me!

Works fine and fixes the incoherence-after-shifting regression on GLM-4-32B-0414 and GLM-4.7-Flash.

Much appreciated.

ORippler added a commit to ORippler/llama.cpp that referenced this pull request Feb 4, 2026
@ORippler
Rename variables + fix rope_neox
1e6d383 
Seems memory layout is shared with Vulkan so we can port fix from
ggml-org#19299
@ORippler ORippler mentioned this pull request Feb 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0cc4m 0cc4m Awaiting requested review from 0cc4m 0cc4m is a code owner

1 more reviewer

@LostRuins LostRuins LostRuins approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffbolznv @LostRuins