qwen3next : fix chunking #19321
Closed
qwen3next : fix chunking #19321
+55
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Superseded by #19324 |
ggerganov
commented
Feb 4, 2026
| ggml_row_size(core_attn_out->type, S_v), | ||
| ggml_row_size(core_attn_out->type, S_v * chunk_size * n_chunks), | ||
| ggml_row_size(core_attn_out->type, S_v * chunk_size * n_chunks * H_v), 0); | ||
| output_tokens = ggml_cont(ctx0, output_tokens); |
Member
Author
There was a problem hiding this comment.
@ngxson Btw, this cont seems redundant still.
Anyway, not very important. I think there is a lot to improve in this graph - will take a look in the next days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel #19305
Based on my analysis in #19305 (comment) I am just restoring the old chunking logic. This seems to resolve the reported issue.
Note that I am blindly restoring the old code, and still haven't understood in details what this logic actually does. So extra look, logprobs tests and validation would be needed before we merge this. Draft for now.