Clean Drupal's packaging script information on info.yml files#62
Open
piggito wants to merge 1 commit intogigya:developfrom
Open
Clean Drupal's packaging script information on info.yml files#62piggito wants to merge 1 commit intogigya:developfrom
piggito wants to merge 1 commit intogigya:developfrom
Conversation
piggito
force-pushed
the
clean_packaging_script_information
branch
from
56aabc1 to
c5e9685
Compare
piggito
force-pushed
the
clean_packaging_script_information
branch
from
c5e9685 to
95434fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to https://www.drupal.org/docs/creating-custom-modules/let-drupal-know-about-your-module-with-an-infoyml-file#s-complete-example at the end of this section you can see that
vesionandprojectare restricted properties which should only be added by Drupal packaging system.Moreover, core's update module uses these properties to determine the project's update status which results in an
Unsupportedreport for gigya module as it was marked like that on drupal.orgThis PR also removes
datestampproperty cause it is also useless now as it is also used by update module to look for changes in project status.