Only load gigya libraries when actually needed.#76
Open
piggito wants to merge 3 commits intogigya:developfrom
Open
Only load gigya libraries when actually needed.#76piggito wants to merge 3 commits intogigya:developfrom
piggito wants to merge 3 commits intogigya:developfrom
Conversation
piggito
force-pushed
the
attachment_library
branch
from
f9971aa to
5814a9f
Compare
Contributor
Author
|
Included changes to attach drupalSettings for customScreenSets on block build for a more modular approach. |
Collaborator
|
Hi, sorry for taking so long to review, but can you briefly explain why the part where it builds the block info for the front-end (on the server-side) is unnecessary? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading external libraries decreases page performance so we should avoid loading gigya's libraries in all pages.
Instead, we can attach gigya libraries to each one of the blocks which actually use them so we only load the libraries when the blocks get rendered.