Skip to content

Code Review Bench PR #64127 - [release/10.0] Source code updates from dotnet/dotnet #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ketkarameya wants to merge 14 commits into from
Closed

Code Review Bench PR #64127 - [release/10.0] Source code updates from dotnet/dotnet #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6bbafe2
Update dependencies from https://github.com/dotnet/dotnet build 287866
dotnet-maestro[bot] Oct 21, 2025
2714a71
Update dependencies from https://github.com/dotnet/dotnet build 287966
dotnet-maestro[bot] Oct 22, 2025
3d46854
Update dependencies from https://github.com/dotnet/dotnet build 288065
dotnet-maestro[bot] Oct 23, 2025
e708649
Update dependencies from https://github.com/dotnet/dotnet build 288391
dotnet-maestro[bot] Oct 24, 2025
7cc6184
Update dependencies from https://github.com/dotnet/dotnet build 288435
dotnet-maestro[bot] Oct 25, 2025
47d7628
Update dependencies from https://github.com/dotnet/dotnet build 288919
dotnet-maestro[bot] Oct 30, 2025
960f0d2
Update dependencies from https://github.com/dotnet/dotnet build 289051
dotnet-maestro[bot] Oct 31, 2025
c3cc22c
Update dependencies from https://github.com/dotnet/dotnet build 289152
dotnet-maestro[bot] Nov 1, 2025
7de8843
Backflow from https://github.com/dotnet/dotnet / 8ee0cc0 build 289521
dotnet-maestro[bot] Nov 5, 2025
a438570
Update dependencies from https://github.com/dotnet/dotnet build 289521
dotnet-maestro[bot] Nov 5, 2025
a0c72d4
Update dependencies from https://github.com/dotnet/dotnet build 289695
dotnet-maestro[bot] Nov 6, 2025
a6fb32e
Quarantine EmbeddingServerAppInsideIframe_WithCompressionEnabled_Fail…
dariatiurina Nov 11, 2025
46847f0
Upgrade to MacOS 15 for CI (#64308)
wtgodbe Nov 11, 2025
b535239
update pr
tomerqodo Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .azure/pipelines/jobs/default-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
# See https://github.com/dotnet/arcade/blob/master/Documentation/ChoosingAMachinePool.md
pool:
${{ if eq(parameters.agentOs, 'macOS') }}:
vmImage: macOS-13
vmImage: macOS-15
${{ if eq(parameters.agentOs, 'Linux') }}:
${{ if eq(parameters.useHostedUbuntu, true) }}:
vmImage: ubuntu-22.04
Expand Down Expand Up @@ -164,7 +164,7 @@ jobs:
displayName: Disk size
- ${{ if eq(parameters.agentOs, 'macOS') }}:
- script: sudo xcode-select -s /Applications/Xcode_15.2.0.app/Contents/Developer
Copy link

@gitar-bot-staging gitar-bot-staging bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bug: Xcode display name says 16.4.0 but script selects 15.2.0

The displayName was changed from "Use XCode 15.2.0" to "Use XCode 16.4.0", but the actual xcode-select command still points to /Applications/Xcode_15.2.0.app/Contents/Developer. This mismatch appears in two places (lines 167 and 393) and will be confusing when debugging CI failures — the pipeline step will say it's using Xcode 16.4.0, but it's actually selecting Xcode 15.2.0. The display name should match the actual Xcode version being selected.

Was this helpful? React with 👍 / 👎

Suggested change
- script: sudo xcode-select -s /Applications/Xcode_15.2.0.app/Contents/Developer
displayName: Use XCode 15.2.0
  • Apply suggested fix

displayName: Use XCode 15.2.0
displayName: Use XCode 16.4.0
- ${{ if and(eq(parameters.agentOs, 'Windows'), eq(parameters.isAzDOTestingJob, true)) }}:
- powershell: ./eng/scripts/InstallProcDump.ps1
displayName: Install ProcDump
Expand Down Expand Up @@ -319,7 +319,7 @@ jobs:
pool:
${{ if eq(parameters.agentOs, 'macOS') }}:
name: Azure Pipelines
image: macOS-13
image: macOS-15
os: macOS
${{ if eq(parameters.agentOs, 'Linux') }}:
name: $(DncEngInternalBuildPool)
Expand Down Expand Up @@ -390,7 +390,7 @@ jobs:
displayName: Disk size
- ${{ if eq(parameters.agentOs, 'macOS') }}:
- script: sudo xcode-select -s /Applications/Xcode_15.2.0.app/Contents/Developer
displayName: Use XCode 15.2.0
displayName: Use XCode 16.4.0
- ${{ if and(eq(parameters.agentOs, 'Windows'), eq(parameters.isAzDOTestingJob, true)) }}:
- powershell: ./eng/scripts/InstallProcDump.ps1
displayName: Install ProcDump
Expand Down
2 changes: 1 addition & 1 deletion NuGet.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<clear />
<!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
<!-- Begin: Package sources from dotnet-dotnet -->
<add key="darc-pub-dotnet-dotnet-c737522" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-dotnet-c737522b/nuget/v3/index.json" />
<add key="darc-pub-dotnet-dotnet-e17b0d0" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-dotnet-e17b0d08/nuget/v3/index.json" />
<!-- End: Package sources from dotnet-dotnet -->
<!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
Expand Down
140 changes: 140 additions & 0 deletions eng/PackageOverrides.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,140 @@
Microsoft.Extensions.Caching.Abstractions|10.0.0
Microsoft.Extensions.Caching.Memory|10.0.0
Microsoft.Extensions.Configuration.Abstractions|10.0.0
Microsoft.Extensions.Configuration.Binder|10.0.0
Microsoft.Extensions.Configuration.CommandLine|10.0.0
Microsoft.Extensions.Configuration|10.0.0
Microsoft.Extensions.Configuration.EnvironmentVariables|10.0.0
Microsoft.Extensions.Configuration.FileExtensions|10.0.0
Microsoft.Extensions.Configuration.Ini|10.0.0
Microsoft.Extensions.Configuration.Json|10.0.0
Microsoft.Extensions.Configuration.UserSecrets|10.0.0
Microsoft.Extensions.Configuration.Xml|10.0.0
Microsoft.Extensions.DependencyInjection.Abstractions|10.0.0
Microsoft.Extensions.DependencyInjection|10.0.0
Microsoft.Extensions.Diagnostics.Abstractions|10.0.0
Microsoft.Extensions.Diagnostics|10.0.0
Microsoft.Extensions.FileProviders.Abstractions|10.0.0
Microsoft.Extensions.FileProviders.Composite|10.0.0
Microsoft.Extensions.FileProviders.Physical|10.0.0
Microsoft.Extensions.FileSystemGlobbing|10.0.0
Microsoft.Extensions.Hosting.Abstractions|10.0.0
Microsoft.Extensions.Hosting|10.0.0
Microsoft.Extensions.Http|10.0.0
Microsoft.Extensions.Logging.Abstractions|10.0.0
Microsoft.Extensions.Logging.Configuration|10.0.0
Microsoft.Extensions.Logging.Console|10.0.0
Microsoft.Extensions.Logging.Debug|10.0.0
Microsoft.Extensions.Logging|10.0.0
Microsoft.Extensions.Logging.EventLog|10.0.0
Microsoft.Extensions.Logging.EventSource|10.0.0
Microsoft.Extensions.Logging.TraceSource|10.0.0
Microsoft.Extensions.Options.ConfigurationExtensions|10.0.0
Microsoft.Extensions.Options.DataAnnotations|10.0.0
Microsoft.Extensions.Options|10.0.0
Microsoft.Extensions.Primitives|10.0.0
System.Diagnostics.EventLog|10.0.0
System.Formats.Cbor|10.0.0
System.Security.Cryptography.Xml|10.0.0
System.Threading.RateLimiting|10.0.0
Microsoft.AspNetCore.Antiforgery|10.0.0
Microsoft.AspNetCore.Authentication.Abstractions|10.0.0
Microsoft.AspNetCore.Authentication.BearerToken|10.0.0
Microsoft.AspNetCore.Authentication.Cookies|10.0.0
Microsoft.AspNetCore.Authentication.Core|10.0.0
Microsoft.AspNetCore.Authentication|10.0.0
Microsoft.AspNetCore.Authentication.OAuth|10.0.0
Microsoft.AspNetCore.Authorization|10.0.0
Microsoft.AspNetCore.Authorization.Policy|10.0.0
Microsoft.AspNetCore.Components.Authorization|10.0.0
Microsoft.AspNetCore.Components|10.0.0
Microsoft.AspNetCore.Components.Endpoints|10.0.0
Microsoft.AspNetCore.Components.Forms|10.0.0
Microsoft.AspNetCore.Components.Server|10.0.0
Microsoft.AspNetCore.Components.Web|10.0.0
Microsoft.AspNetCore.Connections.Abstractions|10.0.0
Microsoft.AspNetCore.CookiePolicy|10.0.0
Microsoft.AspNetCore.Cors|10.0.0
Microsoft.AspNetCore.Cryptography.Internal|10.0.0
Microsoft.AspNetCore.Cryptography.KeyDerivation|10.0.0
Microsoft.AspNetCore.DataProtection.Abstractions|10.0.0
Microsoft.AspNetCore.DataProtection|10.0.0
Microsoft.AspNetCore.DataProtection.Extensions|10.0.0
Microsoft.AspNetCore.Diagnostics.Abstractions|10.0.0
Microsoft.AspNetCore.Diagnostics|10.0.0
Microsoft.AspNetCore.Diagnostics.HealthChecks|10.0.0
Microsoft.AspNetCore|10.0.0
Microsoft.AspNetCore.HostFiltering|10.0.0
Microsoft.AspNetCore.Hosting.Abstractions|10.0.0
Microsoft.AspNetCore.Hosting|10.0.0
Microsoft.AspNetCore.Hosting.Server.Abstractions|10.0.0
Microsoft.AspNetCore.Html.Abstractions|10.0.0
Microsoft.AspNetCore.Http.Abstractions|10.0.0
Microsoft.AspNetCore.Http.Connections.Common|10.0.0
Microsoft.AspNetCore.Http.Connections|10.0.0
Microsoft.AspNetCore.Http|10.0.0
Microsoft.AspNetCore.Http.Extensions|10.0.0
Microsoft.AspNetCore.Http.Features|10.0.0
Microsoft.AspNetCore.Http.Results|10.0.0
Microsoft.AspNetCore.HttpLogging|10.0.0
Microsoft.AspNetCore.HttpOverrides|10.0.0
Microsoft.AspNetCore.HttpsPolicy|10.0.0
Microsoft.AspNetCore.Identity|10.0.0
Microsoft.AspNetCore.Localization|10.0.0
Microsoft.AspNetCore.Localization.Routing|10.0.0
Microsoft.AspNetCore.Metadata|10.0.0
Microsoft.AspNetCore.Mvc.Abstractions|10.0.0
Microsoft.AspNetCore.Mvc.ApiExplorer|10.0.0
Microsoft.AspNetCore.Mvc.Core|10.0.0
Microsoft.AspNetCore.Mvc.Cors|10.0.0
Microsoft.AspNetCore.Mvc.DataAnnotations|10.0.0
Microsoft.AspNetCore.Mvc|10.0.0
Microsoft.AspNetCore.Mvc.Formatters.Json|10.0.0
Microsoft.AspNetCore.Mvc.Formatters.Xml|10.0.0
Microsoft.AspNetCore.Mvc.Localization|10.0.0
Microsoft.AspNetCore.Mvc.Razor|10.0.0
Microsoft.AspNetCore.Mvc.RazorPages|10.0.0
Microsoft.AspNetCore.Mvc.TagHelpers|10.0.0
Microsoft.AspNetCore.Mvc.ViewFeatures|10.0.0
Microsoft.AspNetCore.OutputCaching|10.0.0
Microsoft.AspNetCore.RateLimiting|10.0.0
Microsoft.AspNetCore.Razor|10.0.0
Microsoft.AspNetCore.Razor.Runtime|10.0.0
Microsoft.AspNetCore.RequestDecompression|10.0.0
Microsoft.AspNetCore.ResponseCaching.Abstractions|10.0.0
Microsoft.AspNetCore.ResponseCaching|10.0.0
Microsoft.AspNetCore.ResponseCompression|10.0.0
Microsoft.AspNetCore.Rewrite|10.0.0
Microsoft.AspNetCore.Routing.Abstractions|10.0.0
Microsoft.AspNetCore.Routing|10.0.0
Microsoft.AspNetCore.Server.HttpSys|10.0.0
Microsoft.AspNetCore.Server.IIS|10.0.0
Microsoft.AspNetCore.Server.IISIntegration|10.0.0
Microsoft.AspNetCore.Server.Kestrel.Core|10.0.0
Microsoft.AspNetCore.Server.Kestrel|10.0.0
Microsoft.AspNetCore.Server.Kestrel.Transport.NamedPipes|10.0.0
Microsoft.AspNetCore.Server.Kestrel.Transport.Quic|10.0.0
Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets|10.0.0
Microsoft.AspNetCore.Session|10.0.0
Microsoft.AspNetCore.SignalR.Common|10.0.0
Microsoft.AspNetCore.SignalR.Core|10.0.0
Microsoft.AspNetCore.SignalR|10.0.0
Microsoft.AspNetCore.SignalR.Protocols.Json|10.0.0
Microsoft.AspNetCore.StaticAssets|10.0.0
Microsoft.AspNetCore.StaticFiles|10.0.0
Microsoft.AspNetCore.WebSockets|10.0.0
Microsoft.AspNetCore.WebUtilities|10.0.0
Microsoft.Extensions.Configuration.KeyPerFile|10.0.0
Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions|10.0.0
Microsoft.Extensions.Diagnostics.HealthChecks|10.0.0
Microsoft.Extensions.Features|10.0.0
Microsoft.Extensions.Identity.Core|10.0.0
Microsoft.Extensions.Identity.Stores|10.0.0
Microsoft.Extensions.Localization.Abstractions|10.0.0
Microsoft.Extensions.Localization|10.0.0
Microsoft.Extensions.ObjectPool|10.0.0
Microsoft.Extensions.Validation|10.0.0
Microsoft.Extensions.WebEncoders|10.0.0
Microsoft.JSInterop|10.0.0
Microsoft.Net.Http.Headers|10.0.0
Microsoft.AspNetCore.App|10.0.0
Loading