Code Review Bench PR #26774 - feat: CalendarCache - filter generic calendars from subscription batch

[ketkarameya]

Benchmark PR for Gitar evaluation

Original PR: agentic-review-benchmarks#7

feat: CalendarCache - filter generic calendars from subscription batch

---

Summary by Gitar

• Architecture: Implements Factory + Service + Repository pattern with provider-aware filtering in AdapterFactory, CalendarSubscriptionService, and PrismaSelectedCalendarRepository
• Filtering Logic: Excludes generic calendars (holidays, groups, imported, resources) using provider-specific suffix patterns (@group.v.calendar.google.com, @import.calendar.google.com, etc.) via Prisma query-level AND/NOT conditions
• Extensibility: Centralized GENERIC_CALENDAR_SUFFIXES configuration supports multiple providers (Google Calendar, Office365) with optional parameters ensuring backward compatibility

[gitar-bot-staging]

🚨 Bug: Class rename breaks 3 consumers that import the old name

The class was renamed from SelectedCalendarRepository to PrismaSelectedCalendarRepository in SelectedCalendarRepository.ts, but three files still import and instantiate the old name SelectedCalendarRepository:

1. apps/web/app/api/webhooks/calendar-subscription/[provider]/route.ts — line 14 imports it, line 61 instantiates it
2. apps/web/app/api/cron/calendar-subscriptions/route.ts — line 11 imports it, line 41 instantiates it
3. packages/features/selectedCalendar/repositories/SelectedCalendarRepository.test.ts — line 2 imports it, lines 50 and 53 use it

There is no barrel file or re-export that aliases the old name. This will cause a build failure (import resolution error) for the webhook route, the cron route, and the repository's own test file.

Fix: Either revert the rename (if it wasn't intentional), or update all three consumer files to import PrismaSelectedCalendarRepository instead. A common pattern is to also add a re-export for backward compatibility:

export { PrismaSelectedCalendarRepository as SelectedCalendarRepository };

_{Was this helpful? React with 👍 / 👎}

Suggested change

	export class PrismaSelectedCalendarRepository implements ISelectedCalendarRepository {
	export { PrismaSelectedCalendarRepository as SelectedCalendarRepository };
	export class PrismaSelectedCalendarRepository implements ISelectedCalendarRepository {

• Apply suggested fix

[gitar-bot-staging]

⚠️ This PR is blocked due to unresolved code review findings.

_{Configure merge blocking · Maintainers can dismiss this review. Gitar never approves changes.}

[gitar-bot-staging]

Code Review 🚫 Blocked 0 resolved / 1 findings

The filtering feature is well-designed but the class rename from SelectedCalendarRepository to PrismaSelectedCalendarRepository breaks 3 consumer files (2 route handlers and the test file) that still import the old name — this is a build-breaking change.

🚨 Bug: Class rename breaks 3 consumers that import the old name

📄 packages/features/selectedCalendar/repositories/SelectedCalendarRepository.ts:5

The class was renamed from SelectedCalendarRepository to PrismaSelectedCalendarRepository in SelectedCalendarRepository.ts, but three files still import and instantiate the old name SelectedCalendarRepository:

1. apps/web/app/api/webhooks/calendar-subscription/[provider]/route.ts — line 14 imports it, line 61 instantiates it
2. apps/web/app/api/cron/calendar-subscriptions/route.ts — line 11 imports it, line 41 instantiates it
3. packages/features/selectedCalendar/repositories/SelectedCalendarRepository.test.ts — line 2 imports it, lines 50 and 53 use it

There is no barrel file or re-export that aliases the old name. This will cause a build failure (import resolution error) for the webhook route, the cron route, and the repository's own test file.

Fix: Either revert the rename (if it wasn't intentional), or update all three consumer files to import PrismaSelectedCalendarRepository instead. A common pattern is to also add a re-export for backward compatibility:

export { PrismaSelectedCalendarRepository as SelectedCalendarRepository };

Suggested fix

export { PrismaSelectedCalendarRepository as SelectedCalendarRepository };

export class PrismaSelectedCalendarRepository implements ISelectedCalendarRepository {

Rules 🎸 1 action taken

Gitar Rules

🎸 Summary Enhancement: Appended 'Summary by Gitar' section with 3 technical bullets covering architecture (Factory + Service + Repository pattern), filtering logic (provider-specific suffix patterns with Prisma AND/NOT conditions), and extensibility (centralized configuration with backward compatibility)

_{5 rules not applicable. Show all rules by commenting gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[kayagokalp]

Benchmark Evaluation Results

Ground Truth Bugs (Recall: 1/2 = 50.0%)

ID	Severity	Title	Found?
GT-7-001	Important	Interface-implementation mismatch: integrations parameter op	No
GT-7-002	Critical	Class renamed from SelectedCalendarRepository to PrismaSelec	Yes

Extra Gitar Findings

File	Line	Valid Bug?	Notes
(none)	-	-	-

Summary

• Recall: 50.0% (1/2)
• Precision: 100.0% (1/1)
• Precision counts ground truth matches + valid extra findings as true positives