Mgmt cleanup part 2 #1179
Merged
Mgmt cleanup part 2 #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fredi-raspall
requested review from
sergeymatov
and removed request for
a team
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-2-config-db
branch
from
dbfa537 to
2df0091
Compare
Fredi-raspall
force-pushed
the
pr/fredi/remove_grpc
branch
from
18d421a to
534bc39
Compare
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-2-config-db
branch
from
2df0091 to
23244f2
Compare
Simplifies the configuration database to a minimal one that: - stores a single config (the one being applied). - keeps a history of config changes. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Make apply_gw_config() a method of the ConfigProcessor. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-2-config-db
branch
from
23244f2 to
8b59bae
Compare
Build an internal config for a GwConfig if it does not have it. This should only happen if we roll back to a blank config. We don't build the internal config for a blank config upfront nor try to apply it. We only try to apply such a config if the first config to be applied fails, as a means to clean up. This behavior can be trivially changed by not storing a blank config in the config database. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-2-config-db
branch
from
8b59bae to
237a7ff
Compare
sergeymatov
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes on top of #1165
Summary:
Currently, we only log it.
Note: if we don't attempt to apply a config (because we invalidate it earlier), that will not be shown in the history atm.
This is because our validations are scattered between the converters. Will address this in next PRs.