Fix StreamJsonRpc dependency to be transitive for consumers #37
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request fixes a dependency configuration issue for the StreamJsonRpc package in the GitHub Copilot SDK. The change ensures that consumers of the SDK package receive the necessary runtime dependencies without exposing StreamJsonRpc types in the public API surface.
Changes:
- Modified
PrivateAssetsattribute from "all" to "compile" for the StreamJsonRpc package reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
abpiskunov
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed PrivateAssets=all to PrivateAssets=compile for StreamJsonRpc. This ensures runtime assets flow to package consumers (StreamJsonRpc will be installed automatically) while compile-time assets remain private (the API won't be exposed to consumers).