Skip to content

Conversation

@AngerM
Copy link

@AngerM AngerM commented Jun 7, 2019

Related issue: #739

This moves away from the vendored dependencies and switches to go modules, as well as adding a Dockerfile that contains the gh-ost executable.

The only side-effect was the RelaxedParserMode that you guys had made changes for directly in your vendored version (as opposed to forking it). I dropped the one place that was used. If it's still desired, it would be best to fully fork the gcfg package and make the changes there.

@zmoazeni
Copy link
Contributor

zmoazeni commented Jun 7, 2019

Hey @AngerM did you see my comment at #739 (comment) ?

There's a few dependencies that have changes that aren't upstream.

Are we able to ignore those changes and move to upstream? Some of them seemed important.

@AngerM
Copy link
Author

AngerM commented Jun 7, 2019

The only one that I noticed was the gcfg RelaxedParserMode. For the rest of the packages they seemed to accept upstream versions just fine. We admittedly haven't done extensive testing with this version (or any version) yet in production.

@timvaillancourt
Copy link
Collaborator

@AngerM go modules has been implemented in #935

Can you update the PR if it's still necessary?

@AngerM AngerM closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants