feat: output json option #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds JSON output format support to the bundle list and ec2 status commands, enabling programmatic consumption of deployment status and bundle information. The default output format remains as "table" to maintain backward compatibility.
Key Changes
- Added
--outputflag tobundle listandec2 statuscommands with support for "table" (default) and "json" formats - Refactored output logic into reusable data structures with JSON serialization support
- Renamed
BundleInfotoActiveBundlefor better clarity in the bundler context
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/deployman/main.go | Added --output flag definitions for bundle list and ec2 status commands with enum validation |
| internal/deployer.go | Added JSON-serializable structs (ASGStatus, ELBStatus, TargetStatus, StatusOutput) and output format methods; updated ShowStatus signature to accept outputFormat parameter |
| internal/bundler.go | Added JSON-serializable structs (BundleListItem, BundleListOutput) and output format methods; renamed BundleInfo to ActiveBundle; updated ListBundles signature to accept outputFormat parameter |
| test/e2e_test.go | Updated ListBundles test call to include "table" output format parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.