-
Notifications
You must be signed in to change notification settings - Fork 9
Support for More Than 3 Quick Reply Buttons in HSM Templates #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated HSM Templates documentation: reorganized creation/approval flow, extended Quick Reply support up to 10 items, clarified Static vs Dynamic URL and attachment terminology, expanded bulk‑apply and multi‑language workflows, replaced screenshots, and updated "Last Updated" to December 2025. No code or control‑flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 LanguageTooldocs/4. Product Features/06. HSM Templates.md[grammar] ~60-~60: Use a hyphen to join words. (QB_NEW_EN_HYPHEN) 🪛 markdownlint-cli2 (0.18.1)docs/4. Product Features/06. HSM Templates.md88-88: Unordered list indentation (MD007, ul-indent) 103-103: Emphasis used instead of a heading (MD036, no-emphasis-as-heading) 🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Deployed on https://deploy-preview-526--glific-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/4. Product Features/06. HSM Templates.md(4 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/4. Product Features/06. HSM Templates.md
[grammar] ~59-~59: Use a hyphen to join words.
Context: ...M is selected, this field becomes a drop down. From the list select the element n...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
docs/4. Product Features/06. HSM Templates.md
95-95: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (1)
docs/4. Product Features/06. HSM Templates.md (1)
11-13: Comprehensive documentation improvements well-executed.The reorganization and expansion of the HSM Templates guidance significantly enhance clarity and usability:
- Sub-items (a–n) in the template creation section are well-structured with concise descriptions for each field
- Enhanced explanations for URL handling (Static vs. Dynamic) with practical examples improve user understanding
- New Quick Reply entries (4–10) in the Bulk Apply section properly extend documentation for the expanded 10-button capability
- Inline images are strategically placed to visually support instructions
- Formatting and visual hierarchy improvements make the document easier to navigate
Also applies to: 49-152, 308-314
Fawas003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The main heading ‘HSM Templates’ is missing.
- Update the Last Updated timestamp to December 2025.
- Update the following line, as it is incorrect, ‘Quick Replies is selected by default (Call to action’ is now selected by default in the dropdown).
- Add a screenshot showing how to add a button and select either Call to Action or Quick Reply.
- Update the screenshots for adding buttons, Call to Action, and Quick Reply, as the existing ones are based on the old UI.
- Update the screenshot for adding the ‘HSM Templates’ node in the flow editor (current one uses the old UI).
@Fawas003 which header you are taking about here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (2)
docs/4. Product Features/06. HSM Templates.md (2)
59-59: Fix hyphenation: "drop down" → "drop-down".This issue was flagged in a previous review and remains unresolved.
-Incase the translate existing HSM is selected, this field becomes a drop down. From the list select the element name of the HSM template for which the language variant is being applied. +Incase the translate existing HSM is selected, this field becomes a drop-down. From the list select the element name of the HSM template for which the language variant is being applied.
95-95: Convert bold text to markdown heading (MD036).This issue was flagged in a previous review and remains unresolved. Use a level-3 heading instead of bold emphasis.
-**Static URL** +### Static URL
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/4. Product Features/06. HSM Templates.md(4 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/4. Product Features/06. HSM Templates.md
[grammar] ~59-~59: Use a hyphen to join words.
Context: ...M is selected, this field becomes a drop down. From the list select the element n...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
docs/4. Product Features/06. HSM Templates.md
95-95: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (2)
docs/4. Product Features/06. HSM Templates.md (2)
77-77: Verify default button type matches updated UI behavior.The PR objectives request correcting the statement that "Call to Action is now selected by default in the dropdown," but Line 77 still states "Quick Replies is selected by default." Clarify whether this line should be updated to reflect the new default behavior.
If Call to Action is now the default, update Line 77:
- - Quick Replies is selected by default, which allows adding up to 10 buttons. + - Call to Action is selected by default. Alternatively, Quick Replies can be selected to add up to 10 buttons.Please confirm the current default behavior with the product team before making this change.
308-314: Quick Reply 4–10 expansion approved.The additions of Quick Reply 4 through Quick Reply 10 (lines 308–314) correctly extend support for more than 3 quick reply buttons, directly addressing the PR's stated objective. The formatting and structure are consistent with the existing Quick Reply 1–3 entries.
Is not there before ,but it fine added now. |
|
@CodeRabbit review last two commit |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 882 🏁 Script executed: Length of output: 2837 🏁 Script executed: Length of output: 1352 🏁 Script executed: Length of output: 6685 @priyanshu6238, great progress on the last two commits! Here's my review: ✅ What's been addressed:
🔍 Issues found in the recent changes:Line 82 has a grammar issue: - You can add upto 10 button on Quick Reply option.Should be: - You can add up to 10 buttons in the Quick Reply option.Changes needed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (2)
docs/4. Product Features/06. HSM Templates.md (2)
60-60: Hyphenate compound adjective.This issue was previously flagged. The phrase "drop down" should be hyphenated as "drop-down" to comply with documentation standards.
- d. `Element Name` - Provide a title for WABA namespace for the HSM template. Incase the translate existing HSM is selected, this field becomes a drop down. From the list select the element name of the HSM template for which the language variant is being applied. + d. `Element Name` - Provide a title for WABA namespace for the HSM template. Incase the translate existing HSM is selected, this field becomes a drop-down. From the list select the element name of the HSM template for which the language variant is being applied.
103-103: Replace emphasis with proper markdown heading.This issue was previously flagged. The text "Static URL" uses emphasis instead of a proper heading level, violating markdown linting rules (MD036).
-**Static URL** +### Static URLAlso apply the same fix to line 118, which has "Dynamic URL":
-**Dynamic URL** +### Dynamic URL
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/4. Product Features/06. HSM Templates.md(4 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/4. Product Features/06. HSM Templates.md
[grammar] ~60-~60: Use a hyphen to join words.
Context: ...M is selected, this field becomes a drop down. From the list select the element n...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
docs/4. Product Features/06. HSM Templates.md
88-88: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
103-103: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (1)
docs/4. Product Features/06. HSM Templates.md (1)
316-322: Bulk Apply section correctly expanded for up to 10 Quick Replies.The addition of Quick Reply fields 4–10 (lines 316–322) properly extends the bulk‑apply documentation to support the new limit of up to 10 Quick Reply buttons, maintaining consistent formatting with fields 1–3.
| - Call to action buttons: Add a Call to Action (CTA) button in an HSM (template) message when the recipient is expected to take a specific action directly from the message. | ||
|
|
||
| <img width="366" height="326" alt="Screenshot 2025-12-09 at 1 52 47 PM" src="https://github.com/user-attachments/assets/bdc55bb6-64f6-4d04-9430-3d19ee4acce5" /> | ||
|
|
||
| Here's a simple explanation with examples: | ||
|
|
||
| - There are two main options: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct unordered list indentation.
The nested list items under section "i" use inconsistent indentation that violates markdown standards (MD007). The dashes at lines 88, 93, etc. should align without the 3-space offset, or use a consistent indentation pattern throughout.
i. `Add Buttons` - You can use `Add Buttons` checkbox to use buttons in HSM templates.
- - Call to Action is selected by default. Click the dropdown and select the Quick Replies option.
+ - Call to Action is selected by default. Click the dropdown and select the Quick Replies option.Ensure all nested bullet points (lines 88, 93, and others in this block) follow consistent indentation: either left-aligned or properly nested with 2-space indentation.
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
88-88: Unordered list indentation
Expected: 0; Actual: 3
(MD007, ul-indent)
🤖 Prompt for AI Agents
In docs/4. Product Features/06. HSM Templates.md around lines 88 to 94, the
nested unordered list indentation is inconsistent (MD007); fix by aligning the
top-level dashes at the same column and normalizing nested bullets to a
consistent 2-space indentation level (or left-align all bullets) throughout this
block so each nested item is indented exactly two spaces from its parent and all
list markers line up uniformly.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.