add CheckResponse for Client to check the response#3
Open
xgfone wants to merge 5 commits intoglinton:masterfrom
Open
add CheckResponse for Client to check the response#3xgfone wants to merge 5 commits intoglinton:masterfrom
xgfone wants to merge 5 commits intoglinton:masterfrom
Conversation
glinton
reviewed
Oct 22, 2019
Owner
glinton
left a comment
glinton
left a comment
There was a problem hiding this comment.
Thanks for this, I have a change I will be pushing in a while that may cause some conflicts for this PR. I like what you've added though. Sorry for the delay getting to this.
| @@ -1,4 +1,4 @@ | |||
| package ping_test | |||
Owner
There was a problem hiding this comment.
I do prefer having a separate package for testing libraries unless i'm testing unexported functions directly, which is something that could be done..
Author
There was a problem hiding this comment.
Yes, you are right! I've changed it to the origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket
SOCK_RAWonly returns the response packets by the destination ip. So it will receive all the ICMP responses. If pinging a site concurrently, the request ids of which are not the same, theIDand theSeqof response may not be the same as those of request.However, we can add a function/method for
Clientto check and to filter them until receiving the right response. Of course, we can set it tonilto receiving all the response, but only the first is returned as the response.