Open
Conversation
sreeram77
commented
Aug 20, 2025
- bump go version to 1.25.0
- update x mods
- update actions/checkout, actions/setup-go to latest
Author
|
Hey @urandom |
Author
|
This fixes #45 |
egawata
reviewed
Sep 11, 2025
| module github.com/globusdigital/deep-copy | ||
|
|
||
| go 1.23 | ||
| go 1.25.0 |
Contributor
There was a problem hiding this comment.
@sreeram77
Is it necessary to update go version to 1.25?
Build would fail under environments with go prior to 1.25.
# go version
go version go1.23.12 linux/arm64
# go build .
go: go.mod requires go >= 1.25.0 (running go 1.23.12; GOTOOLCHAIN=local)
Only updating golang.org/x/tools would be enough.
Collaborator
|
Hey @sreeram77 Sorry about the delay. There's a conflict due to another PR merge. Would you be able to resolve it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.