decodeJson should use JSON.parse() when available#69
Open
cynthia wants to merge 1 commit intoglow:masterfrom
Open
decodeJson should use JSON.parse() when available#69cynthia wants to merge 1 commit intoglow:masterfrom
cynthia wants to merge 1 commit intoglow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the decodeJSON() method in data.js does not use JSON.parse(), even when
available. This is possibly because at the point this library was written native parsing did
not exist, but now most modern browsers have support for it.
Using eval() triggers potentially leak-like behavior as it creates a new script context which
is kept around during the lifespan of the application. (for purposes of making it debuggable,
as one reason for this behavior) This change prevents this, which is crucial for memory
constrained platforms like TV/STB/BDPs.