Add architecture support to build scripts and CI #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated build scripts for Lingua, MediaPipe, and Whatlang native projects to require an architecture argument (x86_64 or arm64), and to output architecture-specific library filenames. The GitHub Actions CI workflow was updated to build and collect artifacts for both x86_64 and arm64 architectures across supported platforms.
This reverts commit 0a8b5e9.
Adds Python 3.11 setup to GitHub Actions workflow. Removes unnecessary pipx and python uninstall commands from the macOS build script.
Updated .gitignore and project files to support architecture-specific native binaries (x86_64, arm64) for Lingua, MediaPipe, and Whatlang native projects. Adjusted .csproj files to reference new binary names and package paths, improving multi-architecture support.
Updated the ENTRYPOINT in all native language identification Dockerfiles to pass 'x86_64' as an argument to the run-build.sh script. This standardizes the build architecture across all native components.
Updated the PackagePath for lingua.x86_64.dll to 'runtimes/win-x64/native/lingua.dll' to ensure correct file naming in the package output.
Extended platform detection and packaging to include ARM64 binaries for both Linux and Windows. Updated tests and native library logic to recognize ARM64 architectures, improving cross-platform compatibility.
Updated documentation and project files to indicate and enable ARM64 support for both MediaPipe and Whatlang on Linux and Windows. Adjusted test and runtime checks to include ARM64 Linux, and refactored .csproj files for consistent conditional packaging.
Standardized architecture references from 'AMD64' and 'ARM' to 'x86_64' and 'arm64' in all relevant README files for clarity and consistency across platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build scripts for Lingua, MediaPipe, and Whatlang native projects to require an architecture argument (x86_64 or arm64), and to output architecture-specific library filenames. The GitHub Actions CI workflow was updated to build and collect artifacts for both x86_64 and arm64 architectures across supported platforms.