Conversation
rohan47
force-pushed
the
volume_specification
branch
from
c9ea541 to
87d8c83
Compare
ShyamsundarR
left a comment
ShyamsundarR
left a comment
There was a problem hiding this comment.
The change how it is plugged into the workflow is right, comments needs addressing and also README should change to reflect this new step.
| - name: Set gluster volume specification | ||
| gluster_volume: | ||
| state: "present" | ||
| name: "{{ volume }}" |
There was a problem hiding this comment.
Volume name comes from vc_definition
ansible-playbook-base/site.yml
Outdated
| roles: | ||
| - passwdless-ssh-mesh | ||
|
|
||
| - name: Set gluster volume specification |
There was a problem hiding this comment.
Move this after prepare gluster volumes, we can set options there.
We still want this as a separate step, so that we can invoke it many times for the same volume in reduced testing scenario.
| include_vars: | ||
| file: "{{ vs_definition }}" | ||
| run_once: true | ||
|
|
There was a problem hiding this comment.
Add a play to reset the existing options to defaults, before setting the new options.
| performance.cache-invalidation: 'on' | ||
| performance.md-cache-timeout: '600' | ||
| network.inode-lru-limit: '90000' | ||
| cluster.lookup-optimize: 'on' |
There was a problem hiding this comment.
I would like group options to also be a part of this, not sure if this is handled here, will check and get back on this. IOW, the comment is this yml should allow setting volume group options as well (I suspect that is the one we would be testing with most often)
| @@ -0,0 +1,14 @@ | |||
| --- | |||
| volume: gbenchvol | |||
There was a problem hiding this comment.
Volume name should be from vc_defn so that we do not have to repeat it.. (mentioning here as well so that we do not miss it)
Signed-off-by: rohan47 <rohanrgupta1996@gmail.com>
rohan47
force-pushed
the
volume_specification
branch
from
87d8c83 to
066cb66
Compare
2 participants
Signed-off-by: rohan47 rohanrgupta1996@gmail.com
Ability to set volume options (tuning parameters)