regression.sh: use a zram device for /d when available#213
Open
xhernandez wants to merge 2 commits intogluster:masterfrom
Open
regression.sh: use a zram device for /d when available#213xhernandez wants to merge 2 commits intogluster:masterfrom
xhernandez wants to merge 2 commits intogluster:masterfrom
Conversation
It has been observed that AWS builder instances are very slow sometimes, apparently because of a limited IOPS. To avoid this issue, the script regression.sh has been modified to try to mount /d on a zram device, which will drastically reduce the number of IOPS sent to AWS disks. If the zram device cannot be created for some reason, it falls back to the old loop device. This change should avoid spurious timeout failures caused by too long executions, and it should also prevent failures in tests that are time-dependent. Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Contributor
Author
|
@mscherer this change should help reduce spurious failures in the regression suite. Could you take a look, please ? If I'm nor wrong, /d is also used to store the built programs. This should be changed. Otherwise all compiled programs will be deleted when regression.sh is run. |
mykaul
reviewed
May 8, 2023
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
|
(unrelated to this patch, we should also build against zram device instead of the EBS disks) |
Contributor
Author
I tried this and it seems to work with the current tests, but builder machines are very limited (2 cores, 4 GiB if I'm not wrong). So adding more pressure to memory may be bad if some test really requires to use a significant amount of space. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been observed that AWS builder instances are very slow sometimes, apparently because of a limited IOPS. To avoid this issue, the script regression.sh has been modified to try to mount /d on a zram device, which will drastically reduce the number of IOPS sent to AWS disks. If the zram device cannot be created for some reason, it falls back to the old loop device.
This change should avoid spurious timeout failures caused by too long executions, and it should also prevent failures in tests that are time-dependent.