Fixed fakeplayer inv editor equipment slots#433
Open
replaceitem wants to merge 3 commits intognembon:masterfrom
Open
Fixed fakeplayer inv editor equipment slots#433replaceitem wants to merge 3 commits intognembon:masterfrom
replaceitem wants to merge 3 commits intognembon:masterfrom
Conversation
Fix `global_nope` NBT data to utilize `components.custom_data` properties as of 1.21.5, inventory_set now uses a more complete NBT tag to successfully add the custom NBT data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the fixes in #420, so that should be merged first.
Fixes the armor and offhand slot not working by using
inventory_set('equipment', p, ..).Also renames the datapack folder names
advancementsandfunctionsto beadvancementandfunction, as changed in 24w21a (1.21).However, since advancements currently do not work for fake player, the updating of the screen from the player still does not work until fake players work with advancements, or another method for detecting inventory changes is used.