CreateTableSuffix add DEFAULT

[jinggangnanyou]

No description provided.

[nelsam]

Can you add a little bit of information about why this is needed? I don't personally use mysql for anything, so I want to make sure that this won't break anything for anyone else.

Also, this needs tests before it can be merged.

[jinggangnanyou]

In MySQL reference manual 5.7:

_CREATE {DATABASE | SCHEMA} [IF NOT EXISTS] db_name
[create_option] ...

create_option: [DEFAULT] {
CHARACTER SET [=] charset_name
| COLLATE [=] collation_name
}_

"DEFAULT" keyword is optional, but in some specific version which I am using, it is required. So I think it is more suitable to add "DEFAULT" keyword to support all the scene.

[nelsam]

Can you be certain that all versions of mysql allow the DEFAULT keyword? I worry that this could break someone else who might be on a version of mysql that doesn't allow it. We may need to add this as an option to the constructor to ensure that we don't break backward compatibility.

Also, this does still need tests.

[jinggangnanyou]

Can you be certain that all versions of mysql allow the DEFAULT keyword? I worry that this could break someone else who might be on a version of mysql that doesn't allow it. We may need to add this as an option to the constructor to ensure that we don't break backward compatibility.

Also, this does still need tests.

Yes, for all the mysql version: 5.6, 5.7, 8.0, allow the DEFAULT keyword. But, it is more suitable to add this as an option to the constructor certainly.