This repository was archived by the owner on Nov 28, 2024. It is now read-only.
Make encodeHeader return a new array#62
Open
Emile-Filteau wants to merge 2 commits intogo-mail:v2from
Open
Conversation
…f modifying the headers pass as param
8a0fb54 to
8f3f176
Compare
Author
|
Not clear why CI is failing for Go 1.2, could it be that gimme stopped supporting 1.2 ? |
2482a33 to
7d16daf
Compare
7d16daf to
feff2ea
Compare
Author
|
@ivy you seem to be the "most recent" contributor (i know it's been a while). Can you take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Arrays in Go are mutable. This method currently replaces all values passed to
SetHeaderby their encoded version.This can be problematic in a scenario that the array passed to
SetHeaderis reused somewhere else in the code.Ex :
In the above example, the recipients passed to
SendMailwill be encoded and result in a501 5.1.3 Bad recipient address syntaxfrom any postfix server.In my opinion, the expected behaviour of
SetHeaderis not to mutate the values passed as arguments.Solution
The proposed change creates a new array of string of the same length as the header values passed in and fill it with the encoded values, therefore not touching the raw ones.