new instance of the struct type for scanjsonvalue #1979#1984
Open
Slitherings wants to merge 1 commit intogo-pg:v10from
Open
new instance of the struct type for scanjsonvalue #1979#1984Slitherings wants to merge 1 commit intogo-pg:v10from
Slitherings wants to merge 1 commit intogo-pg:v10from
Conversation
Collaborator
|
I kind of dropped the ball on that issue and never looped back to it sorry. I can take a closer look at this code locally soon and see if I can come up with a test or point you in a direction for a test. |
Author
All good, keep me posted just trying to help! |
Collaborator
|
@Slitherings is there a unit test to support this change? |
Collaborator
|
Sorry pushing all the wrong buttons, I need to figure out how to get this tested. Ideally we should have a unit test that would have failed before this patch but passes with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pull request, wasn't able to test or make sure but this code looks like a fix towards the Scan JSON value get panic #1979
issue (not sure about the "return nil" code on 269) but aside from that hopefully this can be a step towards fixing this issue, but I saw this as a good time to push a potential fix since pg is in the process of migrating to Bun.