core/api: fix Provider serializer optional fields#20289
Open
natzberg wants to merge 1 commit intogoauthentik:mainfrom
Open
core/api: fix Provider serializer optional fields#20289natzberg wants to merge 1 commit intogoauthentik:mainfrom
natzberg wants to merge 1 commit intogoauthentik:mainfrom
Conversation
Fixes goauthentik#9787 The assigned_backchannel_application_slug and assigned_backchannel_application_name fields in the Provider serializer were causing Pydantic validation errors in the Python client when these fields returned None values. Added required=False to these ReadOnlyField definitions to correctly mark them as optional in the OpenAPI schema, allowing the Python client to handle None values. Also applied the same fix to assigned_application_slug and assigned_application_name for consistency.
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9787The assigned_backchannel_application_slug and assigned_backchannel_application_name fields in the Provider serializer were causing Pydantic validation errors in the Python client when these fields returned None values.
Added required=False to these ReadOnlyField definitions to correctly mark them as optional in the OpenAPI schema, allowing the Python client to handle None values.
Also applied the same fix to assigned_application_slug and assigned_application_name for consistency.
make allwas run after making these changes and no issues were reported.