Add CA certificate bundle path override for SSL issues#316
Open
bananna-droid wants to merge 3 commits intogodotengine:masterfrom
Open
Add CA certificate bundle path override for SSL issues#316bananna-droid wants to merge 3 commits intogodotengine:masterfrom
bananna-droid wants to merge 3 commits intogodotengine:masterfrom
Conversation
Fix for linux for issue 146 Allows users to specify a custom CA certificate bundle path via ca_cert_config.txt configuration file. This addresses SSL certificate validation failures on Linux systems where libgit2's default certificate detection fails. Implementation uses git_libgit2_opts(GIT_OPT_SET_SSL_CERT_LOCATIONS) to set the certificate path at runtime. The feature is opt-in and should have zero impact on existing users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for custom CA certificate bundle path configuration to resolve SSL certificate validation failures.
Fixes
#146
Affected Platforms
This issue affects all platforms (Linux, Windows, macOS), not just Linux:
The plugin appears to be built with OpenSSL on all platforms, which fails to locate system CA certificates without proper configuration.
Testing
Changes
ca_bundle_pathmember andset_ca_bundle_path()method to GitPluginca_cert_config.txtgit_libgit2_opts(GIT_OPT_SET_SSL_CERT_LOCATIONS)for runtime certificate configurationTesting
Tested on Linux with custom CA bundle path. SSL operations (fetch/pull/push) now work correctly when config file is present.
Behavior
Example Config File
# ca_cert_config.txt /etc/ssl/certs/ca-certificates.crtRationale
While ideally libgit2 would auto-detect certificate locations on all systems, this provides users immediate control in environments where auto-detection fails. This follows the same pattern as curl's
--cacertand git'shttp.sslCAInfooptions.