OpenXR: Use GLTFDocument function to get supported extension names#109630
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Aug 21, 2025
Merged
OpenXR: Use GLTFDocument function to get supported extension names#109630Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
dsnopek
reviewed
Aug 15, 2025
aaronfranke
force-pushed
the
openxr-gltf-doc-ext
branch
from
cc61be0 to
7be711e
Compare
dsnopek
approved these changes
Aug 20, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks!
I just tested this with SteamVR (which supports this OpenXR render models extension) with the openxr_render_models demo and it worked fine!
Since this feature was added for Godot 4.5, I feel like fixing this issue for release with 4.5 could make sense, so I'm going to change the milestone. But if other folks disagree, we can switch it back to 4.6
fire
approved these changes
Aug 20, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this code added in PR #107388 with a redundant list of extensions, and this comment:
It's actually not a pain, GLTFDocument has function exactly for this purpose. In fact, this function was actually requested for this purpose but forgotten about. So, this PR uses it. The only complexity still in the OpenXR code is to convert Godot's
HashSet<String>to aVector<const char *>to pass to OpenXR, and the logic has been updated to only resize the arrays once, avoiding dynamic memory allocation.