[4.1] GLTF: Preserve node visibility on import#98879
[4.1] GLTF: Preserve node visibility on import#98879akien-mga merged 1 commit intogodotengine:4.1from
Conversation
|
Shouldn't this be moved to 4.4 milestone? Or removed if it already is? |
|
No it's for 4.1 as it could not be cherry picked, see the description |
modules/gltf/extensions/gltf_document_extension_convert_importer_mesh.cpp
Outdated
Show resolved
Hide resolved
a74846c to
fd10868
Compare
|
Does this change have conflicts for every single minor branch? If not, I'd prefer the min amount of PRs with relevant cherrypick labels (e.g. if the conflict is between 4.3 and master, make a 4.3 PR with 4.2 and 4.1 cherrypick labels). |
|
@akien-mga Unfortunately, it does have conflicts with every single minor branch. 4.1 to 4.2: New function calls were added to 4.2 to 4.3: New 4.3 to master: |
|
Thanks! |
Backport of PR #98874 for Godot 4.1. Due to conflicts, #98878 could not be automatically cherry-picked.
I also included the rename of
ImporterMeshInstance3D *mesh_3dtoimporter_mesh_3dbecause 1) Improved readability and 2) May decrease friction in future backports to have this code similar to master.Note: I am making the assumption that we are still good with cherry-picking things to 4.1 based on the fact that the
cherrypick:4.1label still exists.