Merged
Conversation
micaelalorenzo
force-pushed
the
fix/default-env-use
branch
from
7b64d32 to
b4a0ee4
Compare
nerlichman
approved these changes
Apr 10, 2025
nerlichman
reviewed
Apr 11, 2025
Contributor
nerlichman
left a comment
nerlichman
left a comment
There was a problem hiding this comment.
Should we increase the patch version number and push a new version of the gem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default values for
mailcat_api_keyandmailcat_urlwere returningnilbecause the env variables hadn’t been loaded yet. I changed the default to a proc so they’re only evaluated when needed, ensuring the env variables are accessible by that time.Notes
N/A