-
Notifications
You must be signed in to change notification settings - Fork 1
Release v0.1.10 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.1.10 #12
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module Prest | ||
| VERSION = '0.1.9' | ||
| VERSION = '0.1.10' | ||
| end | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -28,5 +28,5 @@ Gem::Specification.new do |spec| | |||||||||
| spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) } | ||||||||||
| spec.require_paths = ['lib'] | ||||||||||
|
|
||||||||||
| spec.add_dependency 'httparty', '>= 0.20.0', '< 0.23.0' | ||||||||||
| spec.add_dependency 'httparty', '~> 0.24.0' | ||||||||||
|
||||||||||
| spec.add_dependency 'httparty', '~> 0.24.0' | |
| spec.add_dependency 'httparty', '~> 0.24.1' |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version constraint change from '>= 0.20.0', '< 0.23.0' to '~> 0.24.0' represents a significant dependency upgrade that skips httparty versions 0.23.x entirely and restricts to 0.24.x. This could potentially introduce breaking changes for users of this gem. Consider whether this warrants a minor version bump (0.2.0) rather than a patch version (0.1.10), especially if httparty 0.24.0 contains breaking changes from the 0.20-0.22 series. If this is purely a security fix with no breaking changes, document this in the changelog for clarity.
| spec.add_dependency 'httparty', '~> 0.24.0' | |
| spec.add_dependency 'httparty', '>= 0.20.0', '< 0.25.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with copilot here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this was done for security reasons, and after checking the httparty changelog I didn’t see any breaking changes, I think its better to not allow the other versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CHANGELOG.md file should be updated to document this release. Previous releases (0.1.9, 0.1.0, 0.1.1, 0.1.2, 0.1.3, etc.) all have changelog entries. This release should include an entry documenting the httparty dependency update and the security vulnerability it addresses.