Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:

pull_request:

permissions:
contents: read
id-token: write

jobs:
build:
runs-on: ubuntu-latest
Expand All @@ -26,9 +30,10 @@ jobs:
bundler-cache: true
- name: Lint with rubocop
run: bundle exec rubocop
- name: Test & Publish code coverage
uses: paambaati/codeclimate-action@v3.0.0
env:
CC_TEST_REPORTER_ID: ${{secrets.CC_TEST_REPORTER_ID}}
- name: Test
run: bundle exec rspec
- name: Publish code coverage
uses: qltysh/qlty-action/coverage@v2
with:
coverageCommand: bundle exec rspec
oidc: true
files: coverage/.resultset.json
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## [0.1.10] - 2026-02-03

- Update `httparty` to use `0.24.0` or a higher version
- Migrate test coverage CI from Code Climate to Qlty

## [0.1.9] - 2024-10-28

- Update `httparty` to use `0.20.0` or a higher version
Expand Down
85 changes: 47 additions & 38 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,65 +1,74 @@
PATH
remote: .
specs:
prest (0.1.9)
httparty (>= 0.20.0, < 0.23.0)
prest (0.1.10)
httparty (~> 0.24.0)

GEM
remote: https://rubygems.org/
specs:
ast (2.4.2)
diff-lcs (1.5.0)
docile (1.4.0)
httparty (0.20.0)
mime-types (~> 3.0)
ast (2.4.3)
csv (3.3.5)
diff-lcs (1.6.2)
docile (1.4.1)
httparty (0.24.2)
csv
mini_mime (>= 1.0.0)
multi_xml (>= 0.5.2)
json (2.6.2)
mime-types (3.4.1)
mime-types-data (~> 3.2015)
mime-types-data (3.2022.0105)
json (2.18.1)
language_server-protocol (3.17.0.5)
lint_roller (1.1.0)
mini_mime (1.1.5)
multi_xml (0.6.0)
parallel (1.22.1)
parser (3.1.2.0)
parallel (1.27.0)
parser (3.3.10.1)
ast (~> 2.4.1)
racc
prism (1.9.0)
racc (1.8.1)
rainbow (3.1.1)
rake (13.0.6)
regexp_parser (2.5.0)
rexml (3.2.5)
rspec (3.11.0)
rspec-core (~> 3.11.0)
rspec-expectations (~> 3.11.0)
rspec-mocks (~> 3.11.0)
rspec-core (3.11.0)
rspec-support (~> 3.11.0)
rspec-expectations (3.11.0)
rake (13.3.1)
regexp_parser (2.11.3)
rspec (3.13.2)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.6)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.5)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.11.0)
rspec-mocks (3.11.1)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.7)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.11.0)
rspec-support (3.11.0)
rubocop (1.31.2)
rspec-support (~> 3.13.0)
rspec-support (3.13.7)
rubocop (1.84.1)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.1.0.0)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.18.0, < 2.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.49.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.19.1)
parser (>= 3.1.1.0)
ruby-progressbar (1.11.0)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.49.0)
parser (>= 3.3.7.2)
prism (~> 1.7)
ruby-progressbar (1.13.0)
simplecov (0.21.2)
docile (~> 1.1)
simplecov-html (~> 0.11)
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov-html (0.13.2)
simplecov_json_formatter (0.1.4)
unicode-display_width (2.2.0)
unicode-display_width (3.2.0)
unicode-emoji (~> 4.1)
unicode-emoji (4.2.0)

PLATFORMS
arm64-darwin-24
arm64-darwin-21
x86_64-darwin-21
x86_64-linux
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

[![Gem Version](https://badge.fury.io/rb/prest.svg)](https://badge.fury.io/rb/prest)
[![Ruby](https://github.com/gogrow-dev/prest/actions/workflows/main.yml/badge.svg?branch=main)](https://github.com/gogrow-dev/prest/actions/workflows/main.yml)
[![Maintainability](https://api.codeclimate.com/v1/badges/f81b2e00be4d8eaa5e81/maintainability)](https://codeclimate.com/github/gogrow-dev/prest/maintainability)
[![Test Coverage](https://api.codeclimate.com/v1/badges/f81b2e00be4d8eaa5e81/test_coverage)](https://codeclimate.com/github/gogrow-dev/prest/test_coverage)
[![Maintainability](https://qlty.sh/gh/gogrow-dev/projects/prest/maintainability.svg)](https://qlty.sh/gh/gogrow-dev/projects/prest)
[![Code Coverage](https://qlty.sh/gh/gogrow-dev/projects/prest/coverage.svg)](https://qlty.sh/gh/gogrow-dev/projects/prest)

Programmatically communicate with any REST API.

Expand Down
2 changes: 1 addition & 1 deletion lib/prest/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Prest
VERSION = '0.1.9'
VERSION = '0.1.10'
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG.md file should be updated to document this release. Previous releases (0.1.9, 0.1.0, 0.1.1, 0.1.2, 0.1.3, etc.) all have changelog entries. This release should include an entry documenting the httparty dependency update and the security vulnerability it addresses.

Copilot uses AI. Check for mistakes.
end
2 changes: 1 addition & 1 deletion prest.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.add_dependency 'httparty', '>= 0.20.0', '< 0.23.0'
spec.add_dependency 'httparty', '~> 0.24.0'
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CVE reference in the PR description appears to be malformed. CVE-2025-68696 is not a valid CVE identifier format (CVE IDs typically have at least 4 digits but this appears to be using an unconventional format). Please verify the correct CVE identifier for the httparty vulnerability you're trying to address. This is important for proper security tracking and documentation.

Suggested change
spec.add_dependency 'httparty', '~> 0.24.0'
spec.add_dependency 'httparty', '~> 0.24.1'

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint change from '>= 0.20.0', '< 0.23.0' to '~> 0.24.0' represents a significant dependency upgrade that skips httparty versions 0.23.x entirely and restricts to 0.24.x. This could potentially introduce breaking changes for users of this gem. Consider whether this warrants a minor version bump (0.2.0) rather than a patch version (0.1.10), especially if httparty 0.24.0 contains breaking changes from the 0.20-0.22 series. If this is purely a security fix with no breaking changes, document this in the changelog for clarity.

Suggested change
spec.add_dependency 'httparty', '~> 0.24.0'
spec.add_dependency 'httparty', '>= 0.20.0', '< 0.25.0'

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with copilot here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was done for security reasons, and after checking the httparty changelog I didn’t see any breaking changes, I think its better to not allow the other versions

end