all: drop pre go1.16 versions (and unicode tables)#38
Open
thaJeztah wants to merge 2 commits intogolang:masterfrom
Open
all: drop pre go1.16 versions (and unicode tables)#38thaJeztah wants to merge 2 commits intogolang:masterfrom
thaJeztah wants to merge 2 commits intogolang:masterfrom
Conversation
This removes most of the tables that were only supported by older go version, which was added in c4d099d (https://go-review.googlesource.com/83235) I kept the "go1.16" build tag for now, but this can probably be dropped. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Remove the go1.16 build-tag, as go1.16 and before reached EOL. Some changes were needed in the generator code, as it would otherwise produce a new "tables.go" file instead of updating the versioned one. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
|
This PR (HEAD: a7b35a8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/text/+/442797 to see it. Tip: You can toggle comments from me using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits in this patch:
all: drop pre go1.16 versions (and unicode tables)
This removes most of the tables that were only supported by older go version,
which was added in c4d099d
(https://go-review.googlesource.com/83235)
I kept the "go1.16" build tag for now, but this can probably be dropped.
remove go1.16 build-tag
Remove the go1.16 build-tag, as go1.16 and before reached EOL.
Some changes were needed in the generator code, as it would otherwise
produce a new "tables.go" file instead of updating the versioned one.