fix: restore environment variable passing in init container #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed inverted logic in init.c line 989 that prevented container environment variables (including PATH) from being passed to executed processes. The bug was introduced when `?:` operator was incorrectly changed to `? NULL :` during code formatting. Before: new_proc_args->envp ? NULL : environ After: new_proc_args->envp ? new_proc_args->envp : environ This ensures container-specified environment variables are properly preserved in the guest VM.
- Update actions/checkout from v1/v2 to v4 - Update actions/cache from v1 to v4 - Update actions/github-script from v3.0/0.9.0 to v7 This resolves CI failures caused by deprecated action versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug where container environment variables (including PATH) were not being passed to executed processes in the guest VM.
Root Cause
The environment variable logic in
runtime/init-container/src/init.cline 989 was accidentally inverted during code formatting between v0.4.2 and current version.v0.4.2 (working):
Before this fix (broken):
After this fix:
Impact
Test plan