Refactor all_atom_test.py for clarity, reusability, and modular structure#1078
Open
Vruddhi18 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Refactor all_atom_test.py for clarity, reusability, and modular structure#1078Vruddhi18 wants to merge 1 commit intogoogle-deepmind:mainfrom
Vruddhi18 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Vruddhi18
commented
Apr 5, 2025
- Extracted helpers for Vecs and Rigids creation
- Simplified test logic using named parameters and reusable transforms
- Improved test case readability and naming consistency
- Preserved original logic with clearer structure
Author
|
I would like to request the merging of the pull request I submitted. All checks have been successfully validated, and there are no errors present. The changes have been reviewed and approved. Thank you for your attention to this matter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.