Add Ellipsoidal Shell Inertia Tests (Multiple Dimensions) #2987
+70
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…b != c) This addresses the TODO comment from taylorhowell by adding test coverage for ellipsoids with non-equal dimensions. The test verifies that: - Shell inertia values differ across axes when a != b != c - Volume inertia calculation works correctly for different dimensions - Surface area calculation using Thomsen approximation is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for ellipsoid shell inertia calculation when dimensions are unequal (a ≠ b ≠ c), addressing the TODO comment from @TaylorHowell in
test/user/user_objects_test.cc:909.Changes
ShellInertiaEllipsoidDifferentDimensionstest case#include <cmath>for math functionsTest Coverage
The new test verifies:
I = mass * (dim1² + dim2²) / 5for different dimensionsTesting
ShellInertiaEllipsoidtest still passesRelated
Fixes TODO from line 909:
// TODO(taylorhowell): add test for ellipsoid with dimensions: a != b != c