Add AVX support check for x86_64 architecture in MpcOptions.cmake#383
Open
AshAnand34 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for AVX support in the
cmake/MpcOptions.cmakefile to ensure compatibility with specific system architectures. The most important change involves adding a conditional check for the processor type whenMUJOCO_ENABLE_AVXis enabled.Changes to AVX support logic:
cmake/MpcOptions.cmake: Added a conditional check to verify if the processor matchesx86_64|AMD64before includingCheckAvxSupportand retrieving AVX compile options. This ensures AVX options are only applied on supported architectures. Additionally, a fallbackset(AVX_COMPILE_OPTIONS)is added whenMUJOCO_ENABLE_AVXis disabled.