modified tfrecords_path split by / to accomodate windows path as well…#55
Open
prakashr85 wants to merge 1 commit intogoogle-research:masterfrom
Open
modified tfrecords_path split by / to accomodate windows path as well…#55prakashr85 wants to merge 1 commit intogoogle-research:masterfrom
prakashr85 wants to merge 1 commit intogoogle-research:masterfrom
Conversation
…, as path separators are different for windows and linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils.mkdir(tfrecords_path.rsplit("/", 1)[0])this throws error while trying to save tfrecord file on windows machine as the path separator for windows is '\'. Made a simple change to accommodate windows as well.utils.mkdir(os.path.dirname(tfrecords_path))