Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Adds noise distractor options#4

Open
ssnl wants to merge 6 commits intogoogle-research:mainfrom
ssnl:noises
Open

Adds noise distractor options#4
ssnl wants to merge 6 commits intogoogle-research:mainfrom
ssnl:noises

Conversation

@ssnl
Copy link

@ssnl ssnl commented Mar 30, 2022

The main mechanism to add distractors is utils.EnvElementManager objects, each of which conceptually manages the evolution of a certain element. Its methods reset(), step(), and pre_render() are called in main environment respective places. This allows placing all code related to a single distractor in a single place, making it much more readable.

Additionally, the RoboDesk class is broken into a base class RoboDeskBase and subclasses RoboDesk and RoboDeskWithTV. The base class has very detailed parameters for distractors. The subclasses

  1. Specify different xmls (most notably one xml has TV, and one does not), and
  2. Use the distractor parameters appropriate for the corresponding scene.
  3. Provide with an easy-to-use API for distractors: RoboDesk(..., distractor="all") or ="none" or ={'env_light', 'camera'}.
  4. Have different camera viewpoints, specified via CameraSpec.

Notably among EnvElementManagers:

  • The CameraManager is created from CameraSpec and is the definitive entry point to create a rendered view of the scene (as it manages camera location).
  • The ButtonManager models potential noisy button sensor readings, so elements that change wrt them (i.e., indicator lights on desk, and TV hue) should read from its method get_normalized_button.
  • The TVManager loads video files and updates frames to the mujoco model.

This PR is built on top of #3. Let me know how I can better facilitate review.

Finally, if this gets merged, could I be added to readme/acknowledgement/bibtex so that I can help with potential issues people have with the distractor options?

@ssnl ssnl force-pushed the noises branch 3 times, most recently from 7c71af7 to f803b18 Compare April 14, 2022 22:27
@ssnl ssnl force-pushed the noises branch 3 times, most recently from d2d792e to 2973c17 Compare June 8, 2022 04:55
@ssnl ssnl force-pushed the noises branch 4 times, most recently from 57cd9cb to ba0214b Compare June 11, 2022 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant