refactor: [go] replace the generic to specific type when creating jwt#93
Open
fernan542 wants to merge 1 commit intogoogle-wallet:mainfrom
Open
refactor: [go] replace the generic to specific type when creating jwt#93fernan542 wants to merge 1 commit intogoogle-wallet:mainfrom
fernan542 wants to merge 1 commit intogoogle-wallet:mainfrom
Conversation
Contributor
|
Thanks for this. The go samples are actually generated by the template in templates/template.go - it contains placeholders for things like the pass type, which should be used to achieve this fix. Did you want to try that? |
Author
|
Hello, thanks for the explanation, I think it should be included in the main Readme file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating new JWT objects for payload, the classes and object type are using "generic" instead of their actual type.
Imports are moved by auto format.